linux-kernel - Re: [PATCH] selftests: seccomp: fix compile error seccomp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jK0X4uJxbj19ei-4bv3e7imsVqroJtP-E03bYd-9fxS4w@mail.gmail.com>
Date:   Tue, 9 Jan 2018 15:07:04 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Anders Roxell <anders.roxell@...aro.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Shuah Khan <shuah@...nel.org>, Will Drewry <wad@...omium.org>,
        Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH] selftests: seccomp: fix compile error seccomp_bpf

On Fri, Jan 5, 2018 at 6:29 PM, Naresh Kamboju
<naresh.kamboju@...aro.org> wrote:
> On 5 January 2018 at 22:01, Anders Roxell <anders.roxell@...aro.org> wrote:
>> aarch64-linux-gnu-gcc -Wl,-no-as-needed -Wall
>>     -lpthread seccomp_bpf.c -o seccomp_bpf
>> seccomp_bpf.c: In function 'tracer_ptrace':
>> seccomp_bpf.c:1720:12: error: '__NR_open' undeclared
>>     (first use in this function)
>>   if (nr == __NR_open)
>>             ^~~~~~~~~
>> seccomp_bpf.c:1720:12: note: each undeclared identifier is reported
>>     only once for each function it appears in
>> In file included from seccomp_bpf.c:48:0:
>> seccomp_bpf.c: In function 'TRACE_syscall_ptrace_syscall_dropped':
>> seccomp_bpf.c:1795:39: error: '__NR_open' undeclared
>>     (first use in this function)
>>   EXPECT_SYSCALL_RETURN(EPERM, syscall(__NR_open));
>>                                        ^
>> open(2) is a legacy syscall, replaced with openat(2) since 2.6.16.
>> Thus new architectures in the kernel, such as arm64, don't implement
>> these legacy syscalls.
>>
>> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
>
> Thanks for the patch Anders.
> Tested-by: Naresh Kamboju <naresh.kamboju@...aro.org>

Did something change recently? This has built fine on arm64 for a
while -- at least since commit 256d0afb11d6 ("selftests/seccomp: build
and pass on arm64").

-Kees

>
>> ---
>>  tools/testing/selftests/seccomp/seccomp_bpf.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
>> index 24dbf634e2dd..0b457e8e0f0c 100644
>> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
>> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
>> @@ -1717,7 +1717,7 @@ void tracer_ptrace(struct __test_metadata *_metadata, pid_t tracee,
>>
>>         if (nr == __NR_getpid)
>>                 change_syscall(_metadata, tracee, __NR_getppid);
>> -       if (nr == __NR_open)
>> +       if (nr == __NR_openat)
>>                 change_syscall(_metadata, tracee, -1);
>>  }
>>
>> @@ -1792,7 +1792,7 @@ TEST_F(TRACE_syscall, ptrace_syscall_dropped)
>>                                            true);
>>
>>         /* Tracer should skip the open syscall, resulting in EPERM. */
>> -       EXPECT_SYSCALL_RETURN(EPERM, syscall(__NR_open));
>> +       EXPECT_SYSCALL_RETURN(EPERM, syscall(__NR_openat));
>>  }
>>
>>  TEST_F(TRACE_syscall, syscall_allowed)
>> --
>> 2.11.0
>>



-- 
Kees Cook
Pixel Security