linux-kernel - Re: [PATCH] misc/lis3lv02d: Delete an error message for a failed memory allocation in lis3lv02d_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f1bcb25-b2bd-da30-5e9c-60340ceffed7@tremplin-utc.net>
Date:   Tue, 9 Jan 2018 09:11:51 +0100
From:   Éric Piel <eric.piel@...mplin-utc.net>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        kernel-janitors@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] misc/lis3lv02d: Delete an error message for a failed
 memory allocation in lis3lv02d_init_device()

On 08/01/18 22:33, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 8 Jan 2018 22:26:06 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
Thanks, looks fine.

Signed-off-by: Éric Piel <eric.piel@...mplin-utc.net>

Maybe the "Kernel Janitors" can just pick it up?

Cheers,
Éric

> ---
>   drivers/misc/lis3lv02d/lis3lv02d.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/lis3lv02d.c
> index e49888eab87d..ba2bd49c15fa 100644
> --- a/drivers/misc/lis3lv02d/lis3lv02d.c
> +++ b/drivers/misc/lis3lv02d/lis3lv02d.c
> @@ -1172,11 +1172,8 @@ int lis3lv02d_init_device(struct lis3lv02d *lis3)
>   
>   	lis3->reg_cache = kzalloc(max(sizeof(lis3_wai8_regs),
>   				     sizeof(lis3_wai12_regs)), GFP_KERNEL);
> -
> -	if (lis3->reg_cache == NULL) {
> -		printk(KERN_ERR DRIVER_NAME "out of memory\n");
> +	if (!lis3->reg_cache)
>   		return -ENOMEM;
> -	}
>   
>   	mutex_init(&lis3->mutex);
>   	atomic_set(&lis3->wake_thread, 0);
>