linux-kernel - Re: [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180109092112.GJ11344@localhost>
Date:   Tue, 9 Jan 2018 10:21:12 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Johan Hovold <johan@...nel.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Marek Belisko <marek@...delico.com>
Subject: Re: [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup

On Mon, Jan 08, 2018 at 05:36:38PM -0800, Dmitry Torokhov wrote:
> On Mon, Jan 08, 2018 at 02:55:02PM +0100, Johan Hovold wrote:
> > On Mon, Dec 11, 2017 at 11:21:21AM +0100, Johan Hovold wrote:
> > > On Sat, Nov 11, 2017 at 04:43:37PM +0100, Johan Hovold wrote:
> > > > A helper purported to look up a child node based on its name was using
> > > > the wrong of-helper and ended up prematurely freeing the parent of-node
> > > > while searching the whole device tree depth-first starting at the parent
> > > > node.
> > > > 
> > > > Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel")
> > > > Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning")
> > > > Cc: stable <stable@...r.kernel.org>     # 3.7
> > > > Cc: Peter Ujfalusi <peter.ujfalusi@...com>
> > > > Cc: Marek Belisko <marek@...delico.com>
> > > > Signed-off-by: Johan Hovold <johan@...nel.org>
> > > > ---
> > > 
> > > Just wanted to send a reminder about this series. I believe these bugs
> > > need to be fixes regardless of whether MFD-core eventually provides some
> > > means of avoiding such lookups in cell drivers (i.e. the discussion
> > > which appears to have stalled).
> > 
> > Another month, another reminder: Will you pick this series up for 4.16,
> > Dmitry?
> 
> Sorry, I was hoping we'd have some movement in MFD... Applied all 3,
> thank you.

No worries. The MFD changes can be done as follow-ons (when people can
find some spare cycles). I agree with the general direction.

Thanks,
Johan