linux-kernel - RE: [PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM3PR04MB1315C4E150966727F46A4029F5100@AM3PR04MB1315.eurprd04.prod.outlook.com>
Date:   Tue, 9 Jan 2018 09:36:00 +0000
From:   Anson Huang <anson.huang@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Horia Geantă <horia.geanta@....com>,
        Aymen Sghaier <aymen.sghaier@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        "Russell King - ARM Linux" <linux@...linux.org.uk>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Adriana Reus <adriana.reus@....com>,
        Stefan Agner <stefan@...er.ch>,
        Dong Aisheng <dongas86@...il.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock



Best Regards!
Anson Huang


> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@...il.com]
> Sent: 2018-01-09 5:27 PM
> To: Anson Huang <anson.huang@....com>
> Cc: Horia Geantă <horia.geanta@....com>; Aymen Sghaier
> <aymen.sghaier@....com>; Herbert Xu <herbert@...dor.apana.org.au>;
> David S. Miller <davem@...emloft.net>; Rob Herring <robh+dt@...nel.org>;
> Mark Rutland <mark.rutland@....com>; Shawn Guo <shawnguo@...nel.org>;
> Sascha Hauer <kernel@...gutronix.de>; Fabio Estevam
> <fabio.estevam@....com>; Russell King - ARM Linux <linux@...linux.org.uk>;
> Michael Turquette <mturquette@...libre.com>; Stephen Boyd
> <sboyd@...eaurora.org>; Adriana Reus <adriana.reus@....com>; Stefan
> Agner <stefan@...er.ch>; Dong Aisheng <dongas86@...il.com>; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@...r.kernel.org>; linux-clk@...r.kernel.org; linux-
> crypto@...r.kernel.org; moderated list:ARM/FREESCALE IMX / MXC ARM
> ARCHITECTURE <linux-arm-kernel@...ts.infradead.org>; linux-kernel <linux-
> kernel@...r.kernel.org>
> Subject: Re: [PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock
> 
> Hi Anson,
> 
> On Tue, Jan 9, 2018 at 12:51 AM, Anson Huang <Anson.Huang@....com>
> wrote:
> 
> > +   - clocks
> > +      Usage: required if SNVS LP RTC requires explicit enablement of clocks
> > +      Value type: <prop_encoded-array>
> > +      Definition:  A list of phandle and clock specifier pairs describing
> > +          the clocks required for enabling and disabling SNVS LP RTC.
> 
> 
> It is a single clock that is used here, so it would be better to describe the text as:
> 
>       Definition:  A clock specifier describing the clock required for enabling and
> disabling SNVS LP RTC
> 
> > +   - clock-names
> > +      Usage: required if SNVS LP RTC requires explicit enablement of clocks
> > +      Value type: <string>
> > +      Definition: A list of clock name strings in the same order as the
> > +          clocks property.
> 
> and here you must describe that the name should be "snvs-rtc":
> 
>       Definition: Clock name string should be "snvs-rtc".


Agree, thanks. Will resend the patch.

Anson.