[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0e365f53-bb45-2d95-30fb-9a862319df35@linaro.org>
Date: Tue, 9 Jan 2018 09:48:23 +0000
From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To: Dan Carpenter <dan.carpenter@...cle.com>,
Sagar Dharia <sdharia@...eaurora.org>
Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/2] slimbus: qcom-ctrl: fix a NULL test
On 09/01/18 09:26, Dan Carpenter wrote:
> "retries" ends when it is set to -1 and not 0 so that part of the test
> is wrong. This bug would lead to a NULL dereference a couple lines
> later.
>
> Fixes: afbdcc7c384b ("slimbus: Add messaging APIs to slimbus framework")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> Should Greg be added to the MAINTAINERS file for this driver?
>
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index fb1a5e0eb8dd..3ab59209cbdc 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -345,7 +345,7 @@ static int qcom_xfer_msg(struct slim_controller *sctrl,
> }
> }
>
> - if (!retries && !pbuf)
> + if (!pbuf)
> return -ENOMEM;
>
> puc = (u8 *)pbuf;
>
Already fixed at:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1575799.html
Powered by blists - more mailing lists