linux-kernel - Re: [PATCH v7 3/6] perf util: Create function to parse time percent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19b7b227-ea8d-344d-e4bb-eaca3e9a8f86@linux.intel.com>
Date:   Tue, 9 Jan 2018 09:18:57 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v7 3/6] perf util: Create function to parse time percent



On 1/8/2018 10:38 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 08, 2018 at 11:31:49AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Dec 08, 2017 at 09:13:43PM +0800, Jin Yao escreveu:
>>> Current perf report/script/... have a --time option to limit the time
>>> range of output. But right now it only supports absolute time.
>>>
>>> For easy using, now it can support a percent of time usage.
>>>
>>> For example:
>>>
>>> 1. Select the second 10% time slice
>>>     perf report --time 10%/2
>>
>> After applying this patch I'm not being able to get any of these
>> examples to work:
>>
>> [root@...et home]# perf report --header | grep "time of"
>> # time of first sample : 22947.909226
>> # time of last sample : 22948.910704
>> [root@...et home]#
>>
>> Then, when I try the first example:
>>
>> [root@...et home]# perf report --stdio --time 1%-20%
>> Invalid time string
>> # To display the perf.data header info, please use --header/--header-only options.
>> #
>> [root@...et home]#
>>
>> What am I doing wrong?
> 
> Oh well, the way you worded this cset it looked like after applying it I
> would be able to use percents, etc, which is not the case, I'll probably
> need to apply the next patches to _then_ this work as advertised in this
> cset comment.
> 
> Please try to make it clear in the commit messages these details, to
> ease reviewing.
> 
> - Arnaldo
> 

Hi Arnaldo,

Sorry about that.

I will take care next time to try my best to make the patch description 
more clear.

Thanks
Jin Yao