linux-kernel - Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180108.203913.1283013651432416478.davem@davemloft.net>
Date:   Mon, 08 Jan 2018 20:39:13 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     kubakici@...pl
Cc:     lipeng321@...wei.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        salil.mehta@...wei.com
Subject: Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of
 netdev

From: Jakub Kicinski <kubakici@...pl>
Date: Mon, 8 Jan 2018 12:04:31 -0800

> Ugh, I so didn't review this in time :(  I think there is a consensus
> that we should avoid duplicating standard stats in ethtool.  Especially
> those old ones.  Like "collisions", I assume this is a modern NIC, are
> collisions still a thing?

There is no standard way to get per-queue values, and ethtool stats are
how pretty much every driver provides it.