linux-kernel - Re: [PATCH][next] ASoC: TSCS42xx: make functions pll_event and dac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180109155227.xlg45ob3rqqme2yz@localhost.localdomain>
Date:   Tue, 9 Jan 2018 08:52:30 -0700
From:   Steven Eckhoff <steven.eckhoff.opensource@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ASoC: TSCS42xx: make functions pll_event and
 dac_event static

On Mon, Jan 08, 2018 at 11:14:44PM +0000, Colin King wrote:

> The functions pll_event and dac_event are local to the source and do
> not need to be in global scope, so make them static.

This looks good to me. Thanks for catching this. You can add:

Reviewed-by: Steven Eckhoff <steven.eckhoff.opensource@...il.com>