linux-kernel - Re: [PATCH 9/8] KVM: x86: limit MSR_IA32_SPEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f15b6d7-6f1e-f578-2310-6dfb639b5771@redhat.com>
Date:   Tue, 9 Jan 2018 17:11:23 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Liran Alon <liran.alon@...cle.com>
Cc:     jmattson@...gle.com, x86@...nel.org, dwmw@...zon.co.uk,
        bp@...en8.de, aliguori@...zon.com, thomas.lendacky@....com,
        rkrcmar@...hat.com, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH 9/8] KVM: x86: limit MSR_IA32_SPEC_CTRL access based on
 CPUID availability

On 09/01/2018 16:58, Liran Alon wrote:
> 
> The only thing I a bit dislike is that currently these MSRs are always pass-through to guest and therefore
> there is no case vmx_set_msr() is called with !msr_info->host_initiated.
> Don't you think we should BUG_ON(!msr_info->host_initiated)?

All this is in flux.  We'll probably get per-VCPU MSR bitmaps anyway
before this patch (which is not part of the initial, minimal fix) is
committed.

Paolo