linux-kernel - Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110135451.4d74135b@vmware.local.home>
Date:   Wed, 10 Jan 2018 13:54:51 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Tejun Heo <tj@...nel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        Cong Wang <xiyou.wangcong@...il.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...nel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        rostedt@...e.goodmis.org, Byungchul Park <byungchul.park@....com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

On Wed, 10 Jan 2018 17:29:00 +0100
Petr Mladek <pmladek@...e.com> wrote:

> he next versions used lazy offload from console_unlock() when
> the thread spent there too much time. IMHO, this is one
> very promising solution. It guarantees that softlockup
> would never happen. But it tries hard to get the messages
> out immediately.
> 
> Unfortunately, it is very complicated. We have troubles to understand
> the concerns, for example see the long discussion about v3 at
> https://lkml.kernel.org/r/20170509082859.854-1-sergey.senozhatsky@gmail.com
> I admit that I did not have enough time to review this.
> 
> 
> Anyway, in October, 2017, Steven came up with a completely
> different approach (console owner/waiter transfer). It does
> not guarantee that the softlockup will not happen. But it
> does not suffer from the problem that blocked the obvious
> solution for years. It moves the owner at runtime, so
> it is guaranteed that the new owner would continue
> printing.

Yes, I believe my solution and the offloading solution are two agnostic
solutions, and they are not mutually exclusive. They both can be
applied. But mine shouldn't be controversial as it has no down sides
from the current printk solution.

After adding this one, if issues come up, we should have a better idea
of how to handle them, because I'm betting the issues will only come up
in some pretty unique scenarios. And they may even be solved without
having to touch printk (and hurt the get out ASAP requirement). I don't
want to paper over some real issues of those that use printk, with
printk work arounds.

-- Steve