linux-kernel - Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110193451.GB3460072@devbig577.frc2.facebook.com>
Date:   Wed, 10 Jan 2018 11:34:51 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        Cong Wang <xiyou.wangcong@...il.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...nel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jan Kara <jack@...e.cz>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        rostedt@...e.goodmis.org, Byungchul Park <byungchul.park@....com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven.

On Wed, Jan 10, 2018 at 02:17:58PM -0500, Steven Rostedt wrote:
> > I'm not really sure why punting to a safe context is necessarily
> > unacceptable in terms of #1 because there seems to be a pretty wide
> > gap between printing useful messages synchronously and a system being
> > caught in printk flush to the point where the system is not
> > operational at all.
> 
> And what do you define as a "safe" context. And what happens when the
> system is hosed and that "safe" context no longer exists? How do you
> know that the safe context is gone?

Hmm.. yeah, we have that problem now too.  Panic bypassing
synchronizations solves some of that I guess.

> I admit now that the OOM net console bug is a real issue. But my
> saying that you were being unrealistic was more about that module you
> posted to try to demonstrate the issue.

Heh, our recollections would differ widely there, but let's leave it
at that.

> Right now my focus is an incremental approach. I'm not trying to solve
> all issues that printk has. I've focused on a single issue, and that is
> that printk is unbounded. Coming from a Real Time background, I find
> that is a big problem. I hate unbounded algorithms. I looked at this
> and found a way to make printk have a max bounded time it can print.
> Sure, it can be more than what you want, but it is a constant time,
> that can be measured. Hence, it is an O(1) solution.

It is bound iff there are contexts which can bounce the flushing role
among them, right?

> Now, if there is still issues with printk, there may be cases where
> offloading makes sense. I don't see why we should stop my solution
> because we are not addressing these other issues where offloading may
> make sense. My solution is simple, and does not impact other solutions.
> It may even show that other solutions are not needed. But that's a good
> thing.
> 
> I'm not against an offloading solution if it can solve issues without
> impacting the other printk use cases. I'm currently only focusing on
> this solution which you are fighting me against.

Oh yeah, sure.  It might actually be pretty simple to combine into
your solution.  For example, can't we just always make sure that
there's at least one sleepable context which participates in your
pingpongs, which only kicks in when a particular context is trapped
too long?

Thanks.

-- 
tejun