linux-kernel - Re: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <236e468acaef47d6847809d09a88ee06@svr-chch-ex1.atlnz.lc>
Date:   Wed, 10 Jan 2018 20:08:31 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Gregory CLEMENT <gregory.clement@...e-electrons.com>
CC:     "jlu@...gutronix.de" <jlu@...gutronix.de>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "bp@...en8.de" <bp@...en8.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jason Cooper <jason@...edaemon.net>,
        "Andrew Lunn" <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on
 db-xc3-24g4xg board

Hi Gregory,

On 10/01/18 21:24, Gregory CLEMENT wrote:
> Hi Chris,
> 
>   On mar., janv. 09 2018, Chris Packham <chris.packham@...iedtelesis.co.nz> wrote:
> 
> Could you have add a (even small) message in the commit log?
> 
> Also could you improve the title by specify that it applies on
> armada-xp, like this:
> 
> ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg
>

Will do.

>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>   arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
>> index 06fce35d7491..00ca489fc788 100644
>> --- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
>> +++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
>> @@ -70,6 +70,11 @@
>>   	};
>>   };
>>   
>> +&L2 {
>> +	arm,parity-enable;
>> +	marvell,ecc-enable;
> 
> It is not a problem for me to already applied the device tree change
> even if the driver is not merged yet. But I would like to have an
> acked-by on this new property by either a device tree maintainer or at
> least the EDAC maintainer, of course having both acked-by would be
> perfect ! :)

Thanks, I was hoping you would say that. That way I can keep this 
independent of the EDAC driver changes.

> 
> Thanks,
> 
> Gregory
> 
> 
> 
> 
>> +};
>> +
>>   &devbus_bootcs {
>>   	status = "okay";
>>   
>> -- 
>> 2.15.1
>>
>