linux-kernel - Re: [PATCH] leds: ledtrig-transient: Add SPDX license identifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 21:40:43 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Shuah Khan <shuahkh@....samsung.com>, rpurdie@...ys.net,
        pavel@....cz, keescook@...omium.org, shuah@...nel.org
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: ledtrig-transient: Add SPDX license identifiers

Hi Shuah,

Thanks for the patch.

On 01/10/2018 05:35 PM, Shuah Khan wrote:
> Replace GPL license statements with SPDX GPL-2.0 license identifiers
> and and correct the module license to GPLv2.
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>  drivers/leds/trigger/ledtrig-transient.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigger/ledtrig-transient.c
> index 7acce64b692a..f0578af858e7 100644
> --- a/drivers/leds/trigger/ledtrig-transient.c
> +++ b/drivers/leds/trigger/ledtrig-transient.c
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*

How about changing this whole block comment to "//"?
We did it already for drivers/leds/trigger/ledtrig-netdev.c,
present in linux-next. See related discussion with reference
to relevant Linus' guidelines in this matter [0].

>   * LED Kernel Transient Trigger
>   *
> @@ -8,10 +9,6 @@
>   * Design and use-case input from Jonas Bonn <jonas@...thpole.se> and
>   * Neil Brown <neilb@...e.de>
>   *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
>   */
>  /*
>   * Transient trigger allows one shot timer activation. Please refer to
> @@ -238,4 +235,4 @@ module_exit(transient_trig_exit);
>  
>  MODULE_AUTHOR("Shuah Khan <shuahkhan@...il.com>");
>  MODULE_DESCRIPTION("Transient LED trigger");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> 

[0] https://www.mail-archive.com/netdev@vger.kernel.org/msg204598.html

-- 
Best regards,
Jacek Anaszewski