linux-kernel - Re: [PATCH 1/2] pinctrl: mediatek: mt7622: fix potential uninitialized value being returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 10:00:49 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     sean.wang@...iatek.com, linus.walleij@...aro.org,
        linux-mediatek@...ts.infradead.org, dan.carpenter@...cle.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: mediatek: mt7622: fix potential
 uninitialized value being returned



On 01/09/2018 05:28 PM, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> commit d6ed93551320 ("pinctrl: mediatek: add pinctrl driver for MT7622
> SoC") leads to the following static checker warning:
> 
> drivers/pinctrl/mediatek/pinctrl-mt7622.c:1419 mtk_gpio_get()
> error: uninitialized symbol 'value'.
> 1412  static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio)
> 1413  {
> 1414          struct mtk_pinctrl *hw = dev_get_drvdata(chip->parent);
> 1415          int value;
> 1416
> 1417          mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
> ^^^^^^^^^^^^^^^^
> 1418
> 1419          return !!value;
> 1420  }
> 
> The appropriate error handling must be added to avoid the potential error
> caused by uninitialized value being returned.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>  drivers/pinctrl/mediatek/pinctrl-mt7622.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt7622.c b/drivers/pinctrl/mediatek/pinctrl-mt7622.c
> index 3824d82..dc32e3c 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mt7622.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt7622.c
> @@ -1412,9 +1412,11 @@ static struct pinctrl_desc mtk_desc = {
>  static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio)
>  {
>  	struct mtk_pinctrl *hw = dev_get_drvdata(chip->parent);
> -	int value;
> +	int value, err;
>  
> -	mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
> +	err = mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
> +	if (err)
> +		return err;
>  
>  	return !!value;
>  }
>