linux-kernel - Re: [PATCH v7 00/10] rockchip: kevin: Enable edp display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb3385c9-8f8d-33fd-8329-0af47490ee46@codeaurora.org>
Date:   Wed, 10 Jan 2018 15:16:22 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Thierry Escande <thierry.escande@...labora.com>,
        Rob Herring <robh+dt@...nel.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sandy Huang <hjc@...k-chips.com>
Cc:     Jeffy Chen <jeffy.chen@...k-chips.com>,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel@...ts.freedesktop.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 00/10] rockchip: kevin: Enable edp display



On 01/09/2018 08:18 PM, Thierry Escande wrote:
> Hi,
> 
> This patchset makes edp display work on Chromebook kevin.
> 
> This patchset has been originally posted by Jeffy Chen and the 2 first
> commits from the previous version (v6) are already merged in mainline.
> This v7 has been rebased on top of next-20180108 and a few conflicts
> have been fixed as well.
> 
> v7:
> Rebased on top of next-20180108 and fixed conflicts
> Fixed a few warnings reported by checkpatch
> 
> Jeffy Chen (10):
>    arm64: dts: rockchip: Enable edp disaplay on kevin
>    drm/rockchip: analogix_dp: Remove unnecessary init code
>    drm/bridge: analogix: Do not use device's drvdata
>    drm/bridge: analogix_dp: Fix connector and encoder cleanup
>    drm/rockchip: analogix_dp: Add a sanity check for
>      rockchip_drm_psr_register()
>    drm/rockchip: dw-mipi-dsi: Fix error handling path
>    drm/rockchip: inno_hdmi: Fix error handling path
>    drm/bridge/synopsys: dw-hdmi: Add missing bridge detach
>    drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata
>    drm/rockchip: dw_hdmi: Fix error handling path


I think all the bridge related patches (#s 1, 2, 6 and 7)have
been reviewed.

I tried to build a kernel with just the 4 of these, and I get
a build error with patch #7 (drm/bridge/synopsys: dw-hdmi: Do not use
device's drvdata). Applying patch #8 (drm/rockchip: dw_hdmi: Fix error
handling path)
fixes this. Could you make these 2 patches independent of each other
so that the kernel builds successfully after each commit?

I don't know if the rest of the rockchip patches in the series
depend on the 4 bridge patches. If they do, the rockchip maintainer
can queue both rockchip and bridge patches. If not, I can pick up
the bridge patches.

Thanks,
Archit

> 
>   arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts  | 29 +++++++
>   arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi       | 16 ++++
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 52 +++++-------
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c          | 53 ++++++------
>   drivers/gpu/drm/exynos/exynos_dp.c                 | 29 ++++---
>   drivers/gpu/drm/imx/dw_hdmi-imx.c                  | 22 +++--
>   drivers/gpu/drm/meson/meson_dw_hdmi.c              | 20 +++--
>   drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c             | 14 +++-
>   drivers/gpu/drm/rockchip/analogix_dp-rockchip.c    | 95 +++++++++++-----------
>   drivers/gpu/drm/rockchip/dw-mipi-dsi.c             | 21 +++--
>   drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c        | 39 +++++----
>   drivers/gpu/drm/rockchip/inno_hdmi.c               | 22 +++--
>   include/drm/bridge/analogix_dp.h                   | 19 +++--
>   include/drm/bridge/dw_hdmi.h                       | 17 ++--
>   14 files changed, 265 insertions(+), 183 deletions(-)
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project