linux-kernel - Re: [PATCH v1 6/8] x86/entry/clearregs: Add number of arguments to syscall tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CEE66310-5B09-4375-8B9F-23D9798C8295@amacapital.net>
Date:   Tue, 9 Jan 2018 17:26:43 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     tglx@...utronix.de, x86@...nel.org, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, dwmw@...zon.co.uk, pjt@...gle.com,
        luto@...nel.org, peterz@...radead.org, thomas.lendacky@....com,
        tim.c.chen@...ux.intel.com, gregkh@...ux-foundation.org,
        dave.hansen@...el.com, jikos@...nel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v1 6/8] x86/entry/clearregs: Add number of arguments to syscall tables



> On Jan 9, 2018, at 5:03 PM, Andi Kleen <andi@...stfloor.org> wrote:
> 
> From: Andi Kleen <ak@...ux.intel.com>
> 
> In order to sanitize the system call arguments properly
> we need to know the number of syscall arguments for each
> syscall. Add a new column to the 32bit and 64bit syscall
> tables to list the number of arguments.
> 

Surely we can do this in the SYSCALL_DEFINE macros.  Or at least statically check it.

Also, what attack are we protecting against anyway?