linux-kernel - [tip:sched/core] sched/fair: Correct obsolete comment about cpufreq_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Jan 2018 04:16:29 -0800
From:   tip-bot for Joel Fernandes <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     tglx@...utronix.de, torvalds@...ux-foundation.org,
        dietmar.eggemann@....com, joelaf@...gle.com, rostedt@...dmis.org,
        hpa@...or.com, peterz@...radead.org, eas-dev@...ts.linaro.org,
        atish.patra@...cle.com, skannan@...cinc.com,
        patrick.bellasi@....com, morten.rasmussen@....com,
        rjw@...ysocki.net, smuckle@...gle.com, Chris.Redpath@....com,
        markivx@...eaurora.org, vincent.guittot@...aro.org,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        viresh.kumar@...aro.org, fweisbec@...il.com,
        srinivas.pandruvada@...ux.intel.com, juri.lelli@....com,
        rohit.k.jain@...cle.com, kernel-team@...roid.com, lenb@...nel.org,
        jbacik@...com
Subject: [tip:sched/core] sched/fair: Correct obsolete comment about
 cpufreq_update_util()

Commit-ID:  9783be2c0e90bbaceec3c471c4fb017bff7293ba
Gitweb:     https://git.kernel.org/tip/9783be2c0e90bbaceec3c471c4fb017bff7293ba
Author:     Joel Fernandes <joelaf@...gle.com>
AuthorDate: Fri, 15 Dec 2017 07:39:43 -0800
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 10 Jan 2018 11:30:30 +0100

sched/fair: Correct obsolete comment about cpufreq_update_util()

Since the remote cpufreq callback work, the cpufreq_update_util() call can happen
from remote CPUs. The comment about local CPUs is thus obsolete. Update it
accordingly.

Signed-off-by: Joel Fernandes <joelaf@...gle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Reviewed-by: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Android Kernel <kernel-team@...roid.com>
Cc: Atish Patra <atish.patra@...cle.com>
Cc: Chris Redpath <Chris.Redpath@....com>
Cc: Dietmar Eggemann <dietmar.eggemann@....com>
Cc: EAS Dev <eas-dev@...ts.linaro.org>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Josef Bacik <jbacik@...com>
Cc: Juri Lelli <juri.lelli@....com>
Cc: Len Brown <lenb@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Morten Ramussen <morten.rasmussen@....com>
Cc: Patrick Bellasi <patrick.bellasi@....com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Rafael J. Wysocki <rjw@...ysocki.net>
Cc: Rohit Jain <rohit.k.jain@...cle.com>
Cc: Saravana Kannan <skannan@...cinc.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc: Steve Muckle <smuckle@...gle.com>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Vikram Mulukutla <markivx@...eaurora.org>
Cc: Vincent Guittot <vincent.guittot@...aro.org>
Link: http://lkml.kernel.org/r/20171215153944.220146-2-joelaf@google.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/sched/fair.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3e7606d..59e66a5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3020,9 +3020,7 @@ static inline void cfs_rq_util_change(struct cfs_rq *cfs_rq)
 		/*
 		 * There are a few boundary cases this might miss but it should
 		 * get called often enough that that should (hopefully) not be
-		 * a real problem -- added to that it only calls on the local
-		 * CPU, so if we enqueue remotely we'll miss an update, but
-		 * the next tick/schedule should update.
+		 * a real problem.
 		 *
 		 * It will not get called when we go idle, because the idle
 		 * thread is a different class (!fair), nor will the utilization