linux-kernel - Re: [PATCH 2/2] platform/x86: surfacepro3: Support for wakeup from suspend-to-idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515590816.7000.857.camel@linux.intel.com>
Date:   Wed, 10 Jan 2018 15:26:56 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux ACPI <linux-acpi@...r.kernel.org>
Cc:     Darren Hart <dvhart@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Valentin Manea <valy@....ro>
Subject: Re: [PATCH 2/2] platform/x86: surfacepro3: Support for wakeup from
 suspend-to-idle

On Wed, 2018-01-10 at 13:26 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Modify surface_button_notify() to make it wake up the system from
> suspend-to-idle (by reporting "hard" wakeup events while suspended)
> and add wakeup initialization to surface_button_add() for wakeup
> events reported by this driver to work at all.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=198389
> Reported-by: Valentin Manea <valy@....ro>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Change seems sane to me.

Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

(in case you would like to push it through PM tree, otherwise I can take
it)

> ---
>  drivers/platform/x86/surfacepro3_button.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/platform/x86/surfacepro3_button.c
> ===================================================================
> --- linux-pm.orig/drivers/platform/x86/surfacepro3_button.c
> +++ linux-pm/drivers/platform/x86/surfacepro3_button.c
> @@ -119,7 +119,7 @@ static void surface_button_notify(struct
>  	if (key_code == KEY_RESERVED)
>  		return;
>  	if (pressed)
> -		pm_wakeup_event(&device->dev, 0);
> +		pm_wakeup_dev_event(&device->dev, 0, button-
> >suspended);
>  	if (button->suspended)
>  		return;
>  	input_report_key(input, key_code, pressed?1:0);
> @@ -185,6 +185,8 @@ static int surface_button_add(struct acp
>  	error = input_register_device(input);
>  	if (error)
>  		goto err_free_input;
> +
> +	device_init_wakeup(&device->dev, true);
>  	dev_info(&device->dev,
>  			"%s [%s]\n", name, acpi_device_bid(device));
>  	return 0;
> 

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy