linux-kernel - Re: [PATCH v6 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU internals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515591166.7000.860.camel@linux.intel.com>
Date:   Wed, 10 Jan 2018 15:32:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Sohil Mehta <sohil.mehta@...el.com>,
        Joerg Roedel <joro@...tes.org>,
        Alex Williamson <alex.williamson@...hat.com>
Cc:     Ashok Raj <ashok.raj@...el.com>,
        David Woodhouse <dwmw2@...radead.org>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Gayatri Kammela <gayatri.kammela@...el.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH v6 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU
 internals

On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:
> From: Gayatri Kammela <gayatri.kammela@...el.com>
> 
> Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs

 
> +config INTEL_IOMMU_DEBUG
> +	bool "Export Intel IOMMU internals in DebugFS"
> +	depends on INTEL_IOMMU && DEBUG_FS

> +	default n

I thought I commented on this...

Please, remove. "n" is default default, so no need to duplicate it.

> +	help
> +	  IOMMU internal states such as context, PASID tables can be
> seen via
> +	  debugfs. Select this option if you want to export these
> internals.
> +
> +	  Say Y if you need this.

Also I lost a track how this option is being used here. It looks like
this part is not related to the patch itself.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy