linux-kernel - Re: [GIT PULL] parisc architecture fixes for 4.15-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ed747e2-d037-b37d-51fb-39e0e2c3f2f4@gmx.de>
Date:   Wed, 10 Jan 2018 14:44:23 +0100
From:   Helge Deller <deller@....de>
To:     Kees Cook <keescook@...omium.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-parisc <linux-parisc@...r.kernel.org>,
        James Bottomley <James.Bottomley@...senpartnership.com>,
        John David Anglin <dave.anglin@...l.net>,
        Richard Henderson <rth@...ddle.net>,
        Laura Abbott <labbott@...hat.com>
Subject: Re: [GIT PULL] parisc architecture fixes for 4.15-rc7

On 10.01.2018 00:03, Kees Cook wrote:
> On Sun, Jan 7, 2018 at 8:21 AM, Helge Deller <deller@....de> wrote:
>> Hi Linus,
>>
>> please pull a few fixes for the parisc architecture from:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git parisc-4.15-3
>>
>> The fixes are:
>> - Many small fixes to show the real physical addresses of devices instead of
>>   hashed addresses.
>>
>> - One important fix to unbreak 32-bit SMP support: We forgot to 16-byte align
>>   the spinlocks in the assembler code.
>>
>> - Qemu support: The host will get a chance to sleep when the parisc guest is
>>   idle. We use the same mechanism as the power architecture by overlaying the
>>   "or %r10,%r10,%r10" instruction which is simply a nop on real hardware.
>>
>> Thanks,
>> Helge
>>
>> ----------------------------------------------------------------
>> Helge Deller (6):
>>       parisc: Show unhashed hardware inventory
>>       parisc: Show unhashed EISA EEPROM address
> 
> These looks like a physical addresses, yes.
> 
>>       parisc: Show initial kernel memory layout unhashed
>>       parisc: Show unhashed HPA of Dino chip
> 
> But these are virtual addresses and should be just removed, not
> switched to %px. They're not physical addresses that I can see, e.g.
> "dino_dev" is clearly being used as an in-memory structure, and the
> kernel layout literally says "virtual kernel memory layout".

Agreed, some of those should go.
I'll clean that up in upcoming patches.

Thanks!
Helge