linux-kernel - Re: [PATCH 3/3] staging: rtl8723bs: Fix trailing semicolon in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180110141500.oxp2bblistv5cklv@mwanda>
Date:   Wed, 10 Jan 2018 17:15:00 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Luis de Bethencourt <luisbg@...nel.org>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Bastien Nocera <hadess@...ess.net>,
        Joe Perches <joe@...ches.com>,
        Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH 3/3] staging: rtl8723bs: Fix trailing semicolon in comment

On Wed, Jan 10, 2018 at 01:50:38PM +0000, Luis de Bethencourt wrote:
> Even though the code is commented out, it has a small bug. The trailing
> semicolon is an empty statement that does no operation. Removing it since
> it doesn't do anything.

It's not a bug because it's totally harmless to add extra semicolons.

But it's better to just delete all the commented out lines.  I don't
really want to see a bunch of patches to code which should just be
deleted.

regards,
dan carpenter