linux-kernel - Re: [PATCH 09/12] perf script: Add support to display lost events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110154438.GA20000@krava>
Date:   Wed, 10 Jan 2018 16:44:38 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCH 09/12] perf script: Add support to display lost events

On Wed, Jan 10, 2018 at 12:40:50PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Jan 07, 2018 at 05:03:53PM +0100, Jiri Olsa escreveu:
> > +++ b/tools/perf/util/event.c
> > +static size_t perf_event__fprintf_lost(union perf_event *event, FILE *fp)
> > +{
> > +	return fprintf(fp, " lost %lu\n", event->lost.lost);
> > +}
> 
> Had to make this:
> 
> 	return fprintf(fp, " lost %" PRIu64 "\n", event->lost.lost);

right, thanks

jirka

> 
> To fix this:
> 
>   CC       /tmp/build/perf/util/event.o
> util/event.c: In function 'perf_event__fprintf_lost':
> util/event.c:1440:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'u64 {aka long long unsigned int}' [-Werror=format=]
>   return fprintf(fp, " lost %lu\n", event->lost.lost);
>                      ^
>   CC       /tmp/build/perf/builtin-script.o
>   CC       /tmp/build/perf/builtin-kmem.o
> cc1: all warnings being treated as errors
> 
>  on these systems:
> 
>   17 debian:experimental-x-mips  : FAIL mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>   19 debian:experimental-x-mipsel: FAIL mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>   25 fedora:24-x-ARC-uClibc      : FAIL arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
>   43 ubuntu:16.04-x-arm          : FAIL arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
>   45 ubuntu:16.04-x-powerpc      : FAIL powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
> 
> - Arnaldo