linux-kernel - Re: [PATCH] crypto: marvell/cesa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110172320.5ab39e43@bbrezillon>
Date:   Wed, 10 Jan 2018 17:23:20 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Robin Murphy <robin.murphy@....com>, arno@...isbad.org,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

Hi Christoph,

On Wed, 10 Jan 2018 16:48:17 +0100
Christoph Hellwig <hch@....de> wrote:

> On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote:
> > On Wed, 10 Jan 2018 15:15:43 +0000
> > Robin Murphy <robin.murphy@....com> wrote:
> >   
> > > phys_to_dma() is an internal helper for certain DMA API implementations,
> > > and is not appropriate for drivers to use. It appears that what the CESA
> > > driver really wants to be using is dma_map_resource() - admittedly that
> > > didn't exist when the offending code was first merged, but it does now.
> > > 
> > > Signed-off-by: Robin Murphy <robin.murphy@....com>  
> > 
> > Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>  
> 
> Thanks.  Robin, Boris: do you want me to pick this up in the
> dma-mapping tree and move it before the dma-direct.h introduction?

You should probably sync with Herbert, I'm just the maintainer of this
driver, not the crypto subsystem.

Regards,

Boris