linux-kernel - Re: [PATCH] kbuild: move cc-option and cc-disable-warning after incl. arch Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATs0F7q=bfCEwt7OTc=g07rEZ0MHSbsfMfFotT+sM5WJw@mail.gmail.com>
Date:   Thu, 11 Jan 2018 01:39:11 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: move cc-option and cc-disable-warning after incl.
 arch Makefile

2018-01-11 1:21 GMT+09:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
> Hi Yamada-san,
>
> On Sun, Dec 10, 2017 at 6:28 AM, Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
>> 2017-11-27 21:25 GMT+09:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
>>> On Mon, Nov 27, 2017 at 1:15 PM, Masahiro Yamada
>>> <yamada.masahiro@...ionext.com> wrote:
>>>> Geert reported commit ae6b289a3789 ("kbuild: Set KBUILD_CFLAGS before
>>>> incl. arch Makefile") broke cross-compilation using a cross-compiler
>>>> that supports less compiler options than the host compiler.
>>>>
>>>> For example,
>>>>
>>>>   cc1: error: unrecognized command line option "-Wno-unused-but-set-variable"
>>>>
>>>> This problem happens on architectures that setup CROSS_COMPILE in their
>>>> arch/*/Makefile.
>>>>
>>>> Move the cc-option and cc-disable-warning back to the original position,
>>>> but keep the Clang target options.
>>>>
>>>> Fixes: ae6b289a3789 ("kbuild: Set KBUILD_CFLAGS before incl. arch Makefile")
>>>> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>>
>>> Thanks for the quick response!
>>>
>>> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>>
>> Applied to linux-kbuild/fixes.
>
> Any chance this will be fixed in v4.15?
> It fixes a regression introduced in v4.15-rc1.
>

Yes, of course.

I have queued up just two patches to the fixes branch.
I am expecting a little more fixes for make-cache issues,
but otherwise, I will send a pull request in a few days.


-- 
Best Regards
Masahiro Yamada