linux-kernel - Re: 答复: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f1c7c53d-0c7f-e66e-2d0f-f5d12486c627@redhat.com>
Date:   Wed, 10 Jan 2018 16:00:51 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     "Zengtao (B)" <prime.zeng@...ilicon.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "Chenfeng (puck)" <puck.chen@...ilicon.com>
Cc:     "sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "arve@...roid.com" <arve@...roid.com>,
        "tkjos@...roid.com" <tkjos@...roid.com>,
        "maco@...roid.com" <maco@...roid.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 答复: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting

On 01/09/2018 04:06 AM, Zengtao (B) wrote:
>> -----邮件原件-----
>> 发件人: Dan Carpenter [mailto:dan.carpenter@...cle.com]
>> 发送时间: 2018年1月9日 17:14
>> 收件人: Chenfeng (puck) <puck.chen@...ilicon.com>
>> 抄送: Zengtao (B) <prime.zeng@...ilicon.com>; labbott@...hat.com;
>> sumit.semwal@...aro.org; gregkh@...uxfoundation.org; arve@...roid.com;
>> tkjos@...roid.com; maco@...roid.com; devel@...verdev.osuosl.org;
>> linux-kernel@...r.kernel.org
>> 主题: Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting
>>
>> On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote:
>>>
>>>
>>> On 2018/1/9 18:43, Zeng Tao wrote:
>>>> This issue is introduced by the commit <e7f63771b60e> ("ION: Sys_heap:
>>>> Add cached pool to spead up cached buffer alloc"),
>>
>> Use the Fixes tag.
>>
>> Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached
>> buffer alloc")
>>
> Agree, thanks.
> 

If you're going to be fixing this, it would be good to
fix the other problems pointed out (stop with the
#define of the flags).

Thanks,
Laura