linux-kernel - Re: checkpatch: exclude drivers/staging from if with unnecessary parentheses test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180111150319.86ca6ee1c16b85e4c0e034a0@linux-foundation.org>
Date:   Thu, 11 Jan 2018 15:03:19 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: checkpatch: exclude drivers/staging from if with unnecessary
 parentheses test

On Thu, 11 Jan 2018 12:53:54 -0800 Joe Perches <joe@...ches.com> wrote:

> Greg KH doesn't like this test so exclude the staging directory
> from the implied --strict only test unless --strict is actually
> used on the command-line.
> 

"doesn't like" is rather vague.  What is the objection, specifically?

Also, an example of code which has an "if with unnecessary parentheses"
would help others understand the decision.