linux-kernel - Re: [PATCH net-next V2 2/2] tuntap: XDP transmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <668445bc-5920-23a6-c59f-3b09e2c4fed1@redhat.com>
Date:   Thu, 11 Jan 2018 10:35:10 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Tariq Toukan <tariqt@...lanox.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     mst@...hat.com, jbrouer@...hat.com,
        Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH net-next V2 2/2] tuntap: XDP transmission



On 2018年01月11日 00:11, Tariq Toukan wrote:
>> +EXPORT_SYMBOL(tun_ptr_to_xdp);
>> +
>
> Hi Jason,
> I started getting the following compilation issues.
>
> + make -j24 -s
> net/socket.o: In function `tun_xdp_to_ptr':
> /images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:46: 
> multiple definition of `tun_xdp_to_ptr'
> fs/compat_ioctl.o:/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:46: 
> first defined here
> net/socket.o: In function `tun_ptr_to_xdp':
> /images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:50: 
> multiple definition of `tun_ptr_to_xdp'
> fs/compat_ioctl.o:/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:50: 
> first defined here
> make: *** [vmlinux] Error 1
>
> Seems you missed adding the following ifdef:
> #if defined(CONFIG_TUN) || defined(CONFIG_TUN_MODULE)
>
> Thanks,
> Tariq 

My bad and sorry for that.

It should have been fixed by 
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=1125b008711581a8962ee028e2982d7757093600

Thanks