linux-kernel - [PATCH v2 0/7] pipe: buffer limits fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180111052902.14409-1-ebiggers3@gmail.com>
Date:   Wed, 10 Jan 2018 21:28:55 -0800
From:   Eric Biggers <ebiggers3@...il.com>
To:     linux-fsdevel@...r.kernel.org
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Joe Lawrence <joe.lawrence@...hat.com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Willy Tarreau <w@....eu>,
        Mikulas Patocka <mpatocka@...hat.com>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers3@...il.com>
Subject: [PATCH v2 0/7] pipe: buffer limits fixes and cleanups

This series simplifies the sysctl handler for pipe-max-size and fixes
another set of bugs related to the pipe buffer limits:

- The root user wasn't allowed to exceed the limits when creating new
  pipes.

- There was an off-by-one error when checking the limits, so a limit of
  N was actually treated as N - 1.

- F_SETPIPE_SZ accepted values over UINT_MAX.

- Reading the pipe buffer limits could be racy.

Changed since v1:

  - Added "Fixes" tag to "pipe: fix off-by-one error when checking buffer limits"
  - In pipe_set_size(), checked 'nr_pages' rather than 'size'
  - Fixed commit message for "pipe: simplify round_pipe_size()"

Eric Biggers (7):
  pipe, sysctl: drop 'min' parameter from pipe-max-size converter
  pipe, sysctl: remove pipe_proc_fn()
  pipe: actually allow root to exceed the pipe buffer limits
  pipe: fix off-by-one error when checking buffer limits
  pipe: reject F_SETPIPE_SZ with size over UINT_MAX
  pipe: simplify round_pipe_size()
  pipe: read buffer limits atomically

 fs/pipe.c                 | 57 ++++++++++++++++++++---------------------------
 include/linux/pipe_fs_i.h |  5 ++---
 include/linux/sysctl.h    |  3 ---
 kernel/sysctl.c           | 33 +++++----------------------
 4 files changed, 32 insertions(+), 66 deletions(-)

-- 
2.15.1