linux-kernel - Re: RCU: Call touch_nmi_watchdog() while printing stall warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111004508.GA3320@jagdpanzerIV>
Date:   Thu, 11 Jan 2018 09:45:08 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: RCU: Call touch_nmi_watchdog() while printing stall warnings

On (01/10/18 06:57), Tejun Heo wrote:
[..]
> > diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> > index 9960f8842b31..649c00a9af12 100644
> > --- a/kernel/workqueue.c
> > +++ b/kernel/workqueue.c
> > @@ -48,6 +48,7 @@
> >  #include <linux/moduleparam.h>
> >  #include <linux/uaccess.h>
> >  #include <linux/sched/isolation.h>
> > +#include <linux/nmi.h>
> >  
> >  #include "workqueue_internal.h"
> >  
> > @@ -4473,6 +4474,8 @@ void show_workqueue_state(void)
> >  			if (pwq->nr_active || !list_empty(&pwq->delayed_works))
> >  				show_pwq(pwq);
> >  			spin_unlock_irqrestore(&pwq->pool->lock, flags);
> > +
> > +			touch_nmi_watchdog();
> 
> Can you send a patch w/ signed-off-by adding touch_nmi_watchdog() to
> both outer loops in that function.  Theoretically, we can have a lot
> of pools too.

thanks. will do.

	-ss