linux-kernel - Re: [PATCH v2] drivers/fbtft: Fix indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180111011122.GC23786@eros>
Date:   Thu, 11 Jan 2018 12:11:22 +1100
From:   "Tobin C. Harding" <me@...in.cc>
To:     Jonny Schaefer <schaefer.jonny@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-kernel@...cs.fau.de
Subject: Re: [PATCH v2] drivers/fbtft: Fix indentation

On Wed, Jan 10, 2018 at 06:30:35PM +0100, Jonny Schaefer wrote:
> From: Luis Gerhorst <luis.gerhorst@....de>
> 
> This fixes the checkpatch message:
> 
>     CHECK: Alignment should match open parenthesis
>     #1380: FILE: drivers/staging/fbtft/fbtft-core.c:1380:
>     +		dev_warn(dev,
>     +			"no default functions for regwidth=%d and buswidth=%d\n",
> 

Perhaps:

Checkpatch emits CHECK: Alignment should match open parenthesis

Align code to open parenthesis.

Reasoning:

Patch description should describe the problem then describe what the
patch does (in imperative mood).  Better advice is given in
Documentation/process/submitting-patches.rst section 2

Hope this helps,
Tobin.