linux-kernel - Re: [PATCH v6 0/5] Add Intel IOMMU debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1515634374.60419.14.camel@intel.com>
Date:   Thu, 11 Jan 2018 01:32:15 +0000
From:   "Mehta, Sohil" <sohil.mehta@...el.com>
To:     "joro@...tes.org" <joro@...tes.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>,
        "jacob.jun.pan@...ux.intel.com" <jacob.jun.pan@...ux.intel.com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "Kammela, Gayatri" <gayatri.kammela@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>
Subject: Re: [PATCH v6 0/5] Add Intel IOMMU debugfs support

On Wed, 2018-01-10 at 15:46 +0200, Andy Shevchenko wrote:
> On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:
> > 
> > Hi All,
> > 
> > This series aims to add debugfs support for Intel IOMMU. It exposes
> > IOMMU
> > registers, internal context and dumps individual table entries to
> > help
> > debug
> > Intel IOMMUs.
> > 
> > The first patch does the ground work for the following patches by
> > creating a
> > new Kconfig option - INTEL_IOMMU_DEBUG. It also reorganizes some
> > Intel
> > IOMMU
> > data structures. The next four patches add debugfs support for
> > IOMMU
> > context
> > internals, register contents, PASID internals, and Interrupt
> > remapping
> > in 
> > that order. The information can be accessed in sysfs at
> > '/sys/kernel/debug/intel_iommu/'.
> > 
> Thanks for an update.
> I found small issues, otherwise looks pretty much good.
> 
> P.S. During re-indendation take care of the lines that can be
> combined
> to one line.
> 

Thanks Andy for the review. Will fix the issues that you pointed and
send out the updated series.

Sohil

> > 
> > Regards,
> > Sohil
> > 
> > Changes since v5:
> >  - Change the order of includes to an alphabetical order
> >  - Change seq_printf and seq_puts formatting
> > 
> > Changes since v4:
> >  - Change to a SPDX license tag
> >  - Fix seq_printf formatting and remove leading '\n's
> > 
> > Changes since v3:
> >  - Remove an unused function parameter from some of the functions
> >  - Fix checkpatch.pl warnings
> >  - Remove error reporting for debugfs_create_file functions
> >  - Fix unnecessary reprogramming of the context entries
> >  - Simplify and merge the show context and extended context patch
> > into
> > one
> >  - Remove redundant IOMMU null check under for_each_active_iommu
> >  - Update the commit title to be consistent
> > 
> > Changes since v2:
> >  - Added a macro for seq file operations based on recommendation by
> > Andy 
> >    Shevchenko. The marco can be moved to seq_file.h at a future
> > point
> >  - Changed the debugfs file names to more relevant ones
> >  - Added information for MTRR registers in the regset file
> > 
> > Changes since v1:
> >  - Fixed seq_printf formatting
> >  - Handled the case when Interrupt remapping is not enabled
> > 
> > Gayatri Kammela (4):
> >   iommu/vt-d: Add debugfs support for Intel IOMMU internals
> >   iommu/vt-d: Add debugfs support to show context internals
> >   iommu/vt-d: Add debugfs support to show register contents
> >   iommu/vt-d: Add debugfs support to show Pasid table contents
> > 
> > Sohil Mehta (1):
> >   iommu/vt-d: Add debugfs support for Interrupt remapping
> > 
> >  drivers/iommu/Kconfig             |  10 ++
> >  drivers/iommu/Makefile            |   1 +
> >  drivers/iommu/intel-iommu-debug.c | 346
> > ++++++++++++++++++++++++++++++++++++++
> >  drivers/iommu/intel-iommu.c       |  35 +---
> >  drivers/iommu/intel-svm.c         |   8 -
> >  include/linux/intel-iommu.h       |  34 ++++
> >  include/linux/intel-svm.h         |  10 +-
> >  7 files changed, 407 insertions(+), 37 deletions(-)
> >  create mode 100644 drivers/iommu/intel-iommu-debug.c
> >