linux-kernel - Re: [PATCH v1 2/4] ARM: PWM: add allwinner sun8i R40/V40/T3 pwm support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Jan 2018 13:45:23 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     hao_zhang <hao5781286@...il.com>
Cc:     thierry.reding@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        linux@...linux.org.uk, wens@...e.org, linus.walleij@...aro.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-pwm@...r.kernel.org
Subject: Re: [PATCH v1 2/4] ARM: PWM: add allwinner sun8i R40/V40/T3 pwm
 support.

Hi,

On Thu, Jan 11, 2018 at 07:32:41PM +0800, hao_zhang wrote:
> This patch add allwinner sun8i R40/V40/T3 pwm support.
> 
> Signed-off-by: hao_zhang <hao5781286@...il.com>

I don't really know the PWM framework, so I'll obviously leave that
part to Thierry, but the DT and probe parts look ok.

You have a number of issues with checkpatch though still, please run
./scripts/checkpatch.pl --strict, and once all the issues have been
fixed:
Reviewed-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)