linux-kernel - Re: [PATCH] vfs: remove unused argument in iterate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Jan 2018 15:31:31 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Rakesh Pandit <rakesh@...era.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] vfs: remove unused argument in iterate_bdevs

On Thu, Jan 11, 2018 at 04:04:07PM +0200, Rakesh Pandit wrote:
> Signed-off-by: Rakesh Pandit <rakesh@...era.com>
> ---
>  fs/block_dev.c     |  4 ++--
>  fs/sync.c          | 12 ++++++------
>  include/linux/fs.h |  4 ++--
>  3 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 4a181fc..95eba30 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -2112,7 +2112,7 @@ int __invalidate_device(struct block_device *bdev, bool kill_dirty)
>  }
>  EXPORT_SYMBOL(__invalidate_device);
>  
> -void iterate_bdevs(void (*func)(struct block_device *, void *), void *arg)
> +void iterate_bdevs(void (*func)(struct block_device *))

Sure, after you implement partially applied functions in C, so that we could
do it properly.  Until then - NAK.