linux-kernel - Re: [PATCH] clk: sunxi-ng: defaultly enable DE2 CCU for sun8i/sun50i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180111153928.qys3efun4jjrx4pz@flea.lan>
Date:   Thu, 11 Jan 2018 16:39:28 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Icenowy Zheng <icenowy@...c.io>
Cc:     Chen-Yu Tsai <wens@...e.org>, linux-arm-kernel@...ts.infradead.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...glegroups.com
Subject: Re: [PATCH] clk: sunxi-ng: defaultly enable DE2 CCU for sun8i/sun50i

On Thu, Jan 11, 2018 at 11:04:51AM +0800, Icenowy Zheng wrote:
> As DE2 support for more SoCs are introducing, there's many reports that
> the DE2 is not functional due to DE2 CCU code not included in kernel.
> 
> Defaultly enable DE2 CCU for sun8i/sun50i to reduce this kind of
> problems.
> 
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>

One way to avoid this would have been to add the symbol to the sunxi
and multi_v7 defconfigs...

You're also adding a depends on. This should be explained or at least
mentionned in your commit log.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)