linux-kernel - Re: [PATCH 2/3] objtool: Ignore retpoline alternatives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515692621.22302.384.camel@infradead.org>
Date:   Thu, 11 Jan 2018 17:43:41 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Josh Poimboeuf <jpoimboe@...hat.com>,
        the arch/x86 maintainers <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 2/3] objtool: Ignore retpoline alternatives

On Thu, 2018-01-11 at 09:29 -0800, Linus Torvalds wrote:
> On Thu, Jan 11, 2018 at 8:27 AM, David Woodhouse <dwmw2@...radead.org> wrote:
> >
> > 
> >   Ick, numbers. Use .Lfoo_%= instead.
> > 
> 
> Actually, I think PeterZ is wrong on this one.
> 
> First off, we do *not* use %= in inline asms in the kernel yet, and we
> shouldn't start just because of these.
> 
> Secondly, we use lots of the the "small numbers for local labels" both
> in inline asm and in *.S files.
> 
> I think doing
> 
>        jne 1f
>   ...
>   1:
> 
> is a _hell_ of a lot more legible than
> 
>         jne .LPrefix_%
>     ...
>   .LPrefix_%
> 
> unless you have some *major* reason to use an explicit label name.

OK. I'll change it back.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)