linux-kernel - Re: [PATCH v3 2/5] x86/enter: Create macros to set/clear IBRS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <deb1ee64-443c-670a-d16f-b3c71b963934@linux.intel.com>
Date:   Thu, 11 Jan 2018 13:24:52 -0800
From:   Tim Chen <tim.c.chen@...ux.intel.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@...el.com>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Peter Zijlstra <peterz@...radead.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Ashok Raj <ashok.raj@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/5] x86/enter: Create macros to set/clear IBRS

On 01/11/2018 01:05 PM, Tim Chen wrote:
> On 01/11/2018 08:04 AM, Thomas Gleixner wrote:
>> On Tue, 9 Jan 2018, Tim Chen wrote:
>>> +
>>> +.macro WRMSR_ASM msr_nr:req edx_val:req eax_val:req
>>> +	movl	\msr_nr, %ecx
>>> +	movl	\edx_val, %edx
>>> +	movl	\eax_val, %eax
>>> +.endm
>>
>> This is the most brilliant piece of useless code I've seen in a long time.
>>
>>
>> 	 tglx
>>
> 
> Sorry that was a major brain fart on my part. 
> 

Our internal tester mixed in retpoline with IBRS so we've missed
this.  Will correct our test.

Tim