linux-kernel - Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Jan 2018 18:33:55 -0800
From:   Jeremy McNicoll <jmcnicol@...hat.com>
To:     zhuoweizhang@...oo.com
Cc:     jeremymc@...hat.com, Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: angler: add pstore-ramoops support

On Thu, Dec 28, 2017 at 02:38:29AM -0500, zhuoweizhang@...oo.com wrote:
> From: Zhuowei Zhang <zhuoweizhang@...oo.com>
> 
> Support pstore-ramoops for retrieving kernel oops and panics after reboot.
> 
> The address and configs are taken from the downstream kernel's device tree.
> 
> Signed-off-by: Zhuowei Zhang <zhuoweizhang@...oo.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index dfa08f5..9ce3a6e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -37,4 +37,19 @@
>  			pinctrl-1 = <&blsp1_uart2_sleep>;
>  		};
>  	};
> +
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		ramoops@...00000 {
> +			compatible = "ramoops";
> +			reg = <0 0x1fe00000 0 0x00200000>;

Downstream doesn't use 0x0 to denote 0.  I am fine with this, if 
someone has a concern or issue with it we can change it before merging.


> +			console-size = <0x100000>;
> +			record-size = <0x10000>;
> +			ftrace-size = <0x10000>;
> +			pmsg-size = <0x80000>;

We could pad this with leading 0's but I find this much easier
to read.

> +		};
> +	};
>  };

Thank you very much for taking the time to send this.  


Acked-by: Jeremy McNicoll <jeremymc@...hat.com>