linux-kernel - Re: [PATCH] selftests/x86: Add test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180112073255.GF25517@kroah.com>
Date:   Fri, 12 Jan 2018 08:32:55 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Borislav Petkov <bp@...en8.de>,
        Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Hugh Dickins <hughd@...gle.com>, stable@...r.kernel.org
Subject: Re: [PATCH] selftests/x86: Add test_vsyscall

On Thu, Jan 11, 2018 at 05:16:51PM -0800, Andy Lutomirski wrote:
> This tests that the vsyscall entries do what they're expected to do.
> It also confirms that attempts to read the vsyscall page behave as
> expected.
> 
> If changes are made to the vsyscall code or its memory map handling,
> running this test in all three of vsyscall=none, vsyscall=emulate,
> and vsyscall=native are helpful.
> 
> (Because it's easy, this also compares the vsyscall results to their
>  vDSO equivalents.)
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Andy Lutomirski <luto@...nel.org>
> ---

Tested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

> Note to KAISER backporters: please test this under all three
> vsyscall modes.  Also, in the emulate and native modes, make sure
> that test_vsyscall_64 agrees with the command line or config
> option as to which mode you're in.  It's quite easy to mess up
> the kernel such that native mode accidentally emulates
> or vice versa.
> 
> Greg, etc: please backport this to all your Meltdown-patched
> kernels.  It'll help make sure the patches didn't regress
> vsyscalls.

I will gladly do so, thanks so much for this test.

greg k-h