linux-kernel - RE: [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output widget power state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60213CA7255C53479ADE3BCF0360117F02E7119B@PGSMSX104.gar.corp.intel.com>
Date:   Fri, 12 Jan 2018 08:36:10 +0000
From:   "Kumar, Abhijeet" <abhijeet.kumar@...el.com>
To:     "Koul, Vinod" <vinod.koul@...el.com>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Kp, Jeeja" <jeeja.kp@...el.com>,
        "Prusty, Subhransu S" <subhransu.s.prusty@...el.com>,
        "Singh, Guneshwor O" <guneshwor.o.singh@...el.com>,
        "Tayal, SandeepX" <sandeepx.tayal@...el.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Kumar, Abhijeet" <abhijeet.kumar@...el.com>
Subject: RE: [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output
 widget power state

> can you rephrase this please
	done please review v2! https://patchwork.kernel.org/patch/10159791/

> am not sure I fully understood the problem here
This appears to be an timing issue, while performing a stress test, we found out that sometimes either pin or converters are not powered up. Thus ensuring it that the power state is set correctly.

> how does read help instead of write?
Indeed i'm making use of read instead of write to send the set command. But unlike codec_write, codec_read send the verb synchronously. Maybe if you read the comment while powering up and down afg in hdmi_codec_prepare and hdmi_codec_complete you would understand better. 
"codec_read is preferred over codec_write to set the power state. This way verb is send to set the power state and response is received. So setting power state is ensured without using loop to read the state."

-----Original Message-----
From: Koul, Vinod 
Sent: Friday, January 12, 2018 11:17 AM
To: Kumar, Abhijeet <abhijeet.kumar@...el.com>
Cc: Liam Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>; Jaroslav Kysela <perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>; Kp, Jeeja <jeeja.kp@...el.com>; Prusty, Subhransu S <subhransu.s.prusty@...el.com>; Singh, Guneshwor O <guneshwor.o.singh@...el.com>; Tayal, SandeepX <sandeepx.tayal@...el.com>; alsa-devel@...a-project.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output widget power state

On Thu, Jan 11, 2018 at 05:04:27PM +0530, abhijeet.kumar@...el.com wrote:
> From: Abhijeet Kumar <abhijeet.kumar@...el.com>
> 
> When we change the resolution of DP pannel or hot plug-unplug it while 
> playing an audio clip,sometimes we observe a silent playback(no audio).

can you rephrase this please

> During no audio condition, we have noticed that the power state of the 
> pin or the connector is D3. Optimzing the way we set the power could 
> mitigate the issue.With this changes the verb is sent to set the power

space after .

> state and response is received. Thus ensuring power state is set.

am not sure I fully understood the problem here

> 
> Signed-off-by: Abhijeet Kumar <abhijeet.kumar@...el.com>
> ---
>  sound/soc/codecs/hdac_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/hdac_hdmi.c 
> b/sound/soc/codecs/hdac_hdmi.c index f3b4f4dfae6a..e24caecf0a4f 100644
> --- a/sound/soc/codecs/hdac_hdmi.c
> +++ b/sound/soc/codecs/hdac_hdmi.c
> @@ -718,7 +718,7 @@ static void hdac_hdmi_set_power_state(struct 
> hdac_ext_device *edev,  {
>  	if (get_wcaps(&edev->hdac, nid) & AC_WCAP_POWER) {
>  		if (!snd_hdac_check_power_state(&edev->hdac, nid, pwr_state))
> -			snd_hdac_codec_write(&edev->hdac, nid, 0,
> +			snd_hdac_codec_read(&edev->hdac, nid, 0,

how does read help instead of write?

--
~Vinod