linux-kernel - Re: [PATCH v3 19/27] drm: replace devm_ioremap_nocache with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Jan 2018 17:37:01 +0800
From:   Yisheng Xie <xieyisheng1@...wei.com>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        David Airlie <airlied@...ux.ie>, <ysxie@...mail.com>,
        <dri-devel@...ts.freedesktop.org>,
        Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH v3 19/27] drm: replace devm_ioremap_nocache with
 devm_ioremap

Hi Benjamin ,

On 2018/1/9 17:21, Benjamin Gaignard wrote:
> 2017-12-23 12:01 GMT+01:00 Yisheng Xie <xieyisheng1@...wei.com>:
>> > Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> > function with devm_ioremap_nocache, which can just be killed to
>> > save the size of devres.o
> That looks true for arm and arm64 architectures but not, for exemple, for ia64:
> https://elixir.free-electrons.com/linux/v4.15-rc7/source/arch/ia64/mm/ioremap.c
> 
> If there is still one architecture doing a difference between cached
> and uncached
> ioremap we can't remove devm_ioremap_nocache...

Right.

> 
> This patch only concern arm chipsets so we can apply it but that will
> not help you to
> reduce devres size.

Yes, And sorry for disturb. Please ignore about this patch.

Thanks
Yisheng
>