linux-kernel - RE: [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output widget power state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60213CA7255C53479ADE3BCF0360117F02E7124F@PGSMSX104.gar.corp.intel.com>
Date:   Fri, 12 Jan 2018 10:37:28 +0000
From:   "Kumar, Abhijeet" <abhijeet.kumar@...el.com>
To:     Takashi Iwai <tiwai@...e.de>
CC:     "Koul, Vinod" <vinod.koul@...el.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        "Singh, Guneshwor O" <guneshwor.o.singh@...el.com>,
        "Kp, Jeeja" <jeeja.kp@...el.com>,
        "Tayal, SandeepX" <sandeepx.tayal@...el.com>,
        "Prusty, Subhransu S" <subhransu.s.prusty@...el.com>,
        Mark Brown <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: hdac_hdmi: Ensuring proper setting of output
 widget power state

> It's better, but doesn't guarantee that the node reached the given power state.  codec_read assures that the verb is sent and the codec gives the response.  But it means only the target state gets updated, and doesn't mean that the actual state reached.

Thanks Takashi for replying. I guess, I  should make use of return value from codec_read and retry if power state is not set properly! I'll make those changes and update again. And just wondering, how does hdmi_codec_prepare() and hdmi_codec_complete() gurantee while powering up and down the afg ?

Warm Regards,
Abhijeet