linux-kernel - Re: [PATCH v1 01/16] virtio: Validate queue pfn for 32bit transports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9c36cb7-8e11-054f-6e20-962839a1d654@arm.com>
Date:   Fri, 12 Jan 2018 11:01:04 +0000
From:   Jean-Philippe Brucker <jean-philippe.brucker@....com>
To:     Peter Maydell <peter.maydell@...aro.org>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Suzuki Poulose <Suzuki.Poulose@....com>,
        arm-mail-list <linux-arm-kernel@...ts.infradead.org>,
        kvm-devel <kvm@...r.kernel.org>,
        "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
        Christoffer Dall <christoffer.dall@...aro.org>,
        Marc Zyngier <Marc.Zyngier@....com>,
        lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kristina Martsenko <Kristina.Martsenko@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Will Deacon <Will.Deacon@....com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Mark Rutland <Mark.Rutland@....com>,
        Catalin Marinas <Catalin.Marinas@....com>,
        Jason Wang <jasowang@...hat.com>,
        Christoffer Dall <cdall@...aro.org>
Subject: Re: [PATCH v1 01/16] virtio: Validate queue pfn for 32bit transports

On 12/01/18 10:21, Peter Maydell wrote:
> On 10 January 2018 at 11:25, Jean-Philippe Brucker
> <jean-philippe.brucker@....com> wrote:
>> Hi Peter,
>>
>> On 10/01/18 11:19, Peter Maydell wrote:
>>> Are there uses that make it worthwhile to get virtio-1
>>> support added to virtio-mmio, rather than just getting
>>> people to move over to virtio-pci instead ?
>>
>> virtio-iommu uses virtio-mmio transport. It makes little sense to have an
>> IOMMU presented as a PCI endpoint.
> 
> Having an entire transport just for the IOMMU doesn't make
> a great deal of sense either though :-) If we didn't already
> have virtio-mmio kicking around would we really have designed
> it that way?
Possibly. It certainly was on the table during early investigations. It
does beat the alternative, having to redesign firmware interfaces and
rewrite core driver code to cater for unrealistic device topologies.

Thanks,
Jean