linux-kernel - Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180112120606.xzmn3ulvpyprza2o@khazad-dum.debian.net>
Date:   Fri, 12 Jan 2018 10:06:06 -0200
From:   Henrique de Moraes Holschuh <hmh@....eng.br>
To:     David Herrmann <dh.herrmann@...il.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        linux-kernel@...r.kernel.org, Matthew Thode <mthode@...ode.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm
 detection

On Fri, 12 Jan 2018, David Herrmann wrote:
> This patch prevents the thinkpad_acpi driver from warning about 2 event
> codes returned for keyboard palm-detection. No behavioral changes,
> other than suppressing the warning in the kernel log. The events are
> still forwarded via acpi-netlink channels.
> 
> We could, optionally, decide to forward the event through a
> input-switch on the tpacpi input device. However, so far no suitable
> input-code exists, and no similar drivers report such events. Hence,
> leave it an acpi event for now.
> 
> Note that the event-codes are named based on empirical studies. On the
> ThinkPad X1 5th Gen the sensor can be found underneath the arrow key.
> 
> Cc: Matthew Thode <mthode@...ode.org>
> Signed-off-by: David Herrmann <dh.herrmann@...il.com>

Well, we certainly should drop the warning, and I am fine with the
current name for the events (they are not ABI in any way, so we can
change that at any time if we find out it should be named differently).

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>

> ---
>  drivers/platform/x86/thinkpad_acpi.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 117be48ff4de..128f91af716e 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -214,6 +214,10 @@ enum tpacpi_hkey_event_t {
>  	/* AC-related events */
>  	TP_HKEY_EV_AC_CHANGED		= 0x6040, /* AC status changed */
>  
> +	/* Further user-interface events */
> +	TP_HKEY_EV_PALM_DETECTED	= 0x60b0, /* palm hoveres keyboard */
> +	TP_HKEY_EV_PALM_UNDETECTED	= 0x60b1, /* palm removed */
> +
>  	/* Misc */
>  	TP_HKEY_EV_RFKILL_CHANGED	= 0x7000, /* rfkill switch changed */
>  };
> @@ -4079,6 +4083,12 @@ static bool hotkey_notify_6xxx(const u32 hkey,
>  		*send_acpi_ev = false;
>  		break;
>  
> +	case TP_HKEY_EV_PALM_DETECTED:
> +	case TP_HKEY_EV_PALM_UNDETECTED:
> +		/* palm detected hovering the keyboard, forward to user-space
> +		 * via netlink for consumption */
> +		return true;
> +
>  	default:
>  		pr_warn("unknown possible thermal alarm or keyboard event received\n");
>  		known = false;

-- 
  Henrique Holschuh