linux-kernel - Re: [x86-tip] RSDP changes converted i4790 box SMP -> UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180112122304.tloxnnkhxq4fbyrn@pd.tnic>
Date:   Fri, 12 Jan 2018 13:23:04 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Mike Galbraith <mgalbraith@...e.de>,
        Juergen Gross <jgross@...e.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [x86-tip] RSDP changes  converted i4790 box  SMP -> UP

On Fri, Jan 12, 2018 at 05:25:28AM +0100, Mike Galbraith wrote:
> Hi Juergen,
> 
> Yesterday I wanted to test the RETPOLINE stuff in tip and tip-rt, but
> discovered instead that my box had turned into a complete slug, not due
> to incredible RETPOLINE overhead, rather because box had forgotten that
> it had more than one CPU.  I was going to leave it for the weekend, but
> firing up gitk over morning java, I noticed the commits below, and sure
> enough, that's what broke my box.  Given other people's boxen work,
> seems likely that the authors of the AMI BIOS in this box were a bit
> more creative than usual.
> 
> commit 9ede5d5e672586e016eadd5c0aedb6f12e660029 (HEAD -> x86-tip)
> Author: Mike Galbraith <mgalbraith@...e.de>
> Date:   Fri Jan 12 04:17:52 2018 +0100
> 
>     Revert "x86/boot: Add the ACPI RSDP address to struct setup_header::acpi_rdsp_addr"
>     
>     This reverts commit 2f74cbf947f45fa082dda8eac1a1f1299a372f49.
> 
> commit 0d0b6a9a0d452eaf635580fce8319d49be8b45ed
> Author: Mike Galbraith <mgalbraith@...e.de>
> Date:   Fri Jan 12 04:17:30 2018 +0100
> 
>     Revert "x86/acpi: Take the RSDP address for boot parameters if available"

I'm seeing a similar irregularity caused by this one above. I did bisect tip
merges and here's my tree state:

e07fcf1e8c1c (HEAD -> refs/heads/rc7+pti) x86/acpi: Take the RSDP address for boot parameters if available
a7d88e8f7b73 x86/boot: Add the ACPI RSDP address to struct setup_header::acpi_rdsp_addr
372349a5e806 Merge remote-tracking branch 'tip/x86/apic' into rc7+pti
8cf749efdb78 Merge remote-tracking branch 'tip/sched/core' into rc7+pti
4720f8a1ddb0 Merge remote-tracking branch 'tip/ras/core' into rc7+pti
...

So tip commit:

0c89cf36424f x86/acpi: Take the RSDP address for boot parameters if available

ontop of rc7 + a bunch of tip branches is the first one which causes
this (maybe it'll help debugging the issue):

[    0.000000] ACPI: Early table checksum verification disabled
[    0.000000] ACPI: \xffffffee    0x0000000000000115 F3F000EE (v238 \xfffffff0\xfffffff3\xffffffee    \xffffffee        F3F000EE \xffffffee    38F000EE)
[    0.000000] ACPI: \xffffffff\xffffffff\xffffffff\xffffffff 0xF3F000EEF3F000EE FFFFFFFF (v255 \xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff \xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff\xffffffff FFFFFFFF \xffffffff\xffffffff\xffffffff\xffffffff FFFFFFFF)
[    0.000000] WARNING: CPU: 0 PID: 0 at mm/early_ioremap.c:145 __early_ioremap+0xd0/0x19e
[    0.000000] Modules linked in:
[    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.15.0-rc7+ #16
[    0.000000] RIP: 0010:__early_ioremap+0xd0/0x19e
[    0.000000] RSP: 0000:ffffffffa4003ce8 EFLAGS: 00010002 ORIG_RAX: 0000000000000000
[    0.000000] RAX: 0000000000000000 RBX: 0000000000100001 RCX: 0000000000100001
[    0.000000] RDX: f3f000eff3f000ec RSI: 00000000000000ee RDI: f3f000eef3f00000
[    0.000000] RBP: ffffffffa4003d40 R08: 0000000000000001 R09: 00000000000000af
[    0.000000] R10: 206e6f6974616369 R11: 4530303046334678 R12: 8000000000000163
[    0.000000] R13: 0000000000000001 R14: f3f000eff3f000ed R15: 0000000000000008
[    0.000000] FS:  0000000000000000(0000) GS:ffffffffa416b000(0000) knlGS:0000000000000000
[    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    0.000000] CR2: ffff94efffdff000 CR3: 000000251700a000 CR4: 00000000000406b0
[    0.000000] Call Trace:
[    0.000000]  early_memremap+0x36/0x3b
[    0.000000]  __acpi_map_table+0x18/0x1d
[    0.000000]  acpi_os_map_iomem+0x135/0x1b0
[    0.000000]  acpi_os_map_memory+0xe/0x10
[    0.000000]  acpi_tb_parse_root_table+0x172/0x29a
[    0.000000]  acpi_initialize_tables+0xd0/0xfb
[    0.000000]  acpi_table_init+0x59/0x1be
[    0.000000]  acpi_boot_table_init+0x23/0x8a
[    0.000000]  setup_arch+0x91e/0xc6d
[    0.000000]  start_kernel+0x5c/0x495
[    0.000000]  x86_64_start_reservations+0x24/0x26
[    0.000000]  x86_64_start_kernel+0x74/0x77
[    0.000000]  secondary_startup_64+0xa5/0xb0
[    0.000000] Code: 65 d0 00 f0 ff ff 81 e6 ff 0f 00 00 48 29 7d d0 48 89 75 c0 48 8b 4d d0 48 89 7d c8 48 c1 e9 0c 83 f9 40 48 89 4d b0 89 cb 76 07 <0f> ff e9 aa 00 00 00 41 6b d0 c0 4c 8b 7d c8 81 eb ff 05 00 00 
[    0.000000] ---[ end trace 84de100369bbea16 ]---
[    0.000000] No NUMA configuration found

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.