linux-kernel - Re: [PATCH v2] crypto: testmgr: change `guard` to unsigned char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180112122328.GC21636@gondor.apana.org.au>
Date:   Fri, 12 Jan 2018 23:23:28 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Joey Pabalinas <joeypabalinas@...il.com>
Cc:     Joe Perches <joe@...ches.com>, linux-crypto@...r.kernel.org,
        davem@...emloft.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] crypto: testmgr: change `guard` to unsigned char

On Mon, Jan 01, 2018 at 10:40:14AM -1000, Joey Pabalinas wrote:
> When char is signed, storing the values 0xba (186) and 0xad (173) in the
> `guard` array produces signed overflow. Change the type of `guard` to
> static unsigned char to correct undefined behavior and reduce function
> stack usage.
> 
> Signed-off-by: Joey Pabalinas <joeypabalinas@...il.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt