linux-kernel - Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Jan 2018 15:07:12 +0100
From:   David Herrmann <dh.herrmann@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matthew Thode <mthode@...ode.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: suppress warning about palm detection

Hi Andy

On Fri, Jan 12, 2018 at 2:50 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Fri, Jan 12, 2018 at 1:04 PM, David Herrmann <dh.herrmann@...il.com> wrote:
>> This patch prevents the thinkpad_acpi driver from warning about 2 event
>> codes returned for keyboard palm-detection. No behavioral changes,
>> other than suppressing the warning in the kernel log. The events are
>> still forwarded via acpi-netlink channels.
>>
>> We could, optionally, decide to forward the event through a
>> input-switch on the tpacpi input device. However, so far no suitable
>> input-code exists, and no similar drivers report such events. Hence,
>> leave it an acpi event for now.
>>
>> Note that the event-codes are named based on empirical studies. On the
>> ThinkPad X1 5th Gen the sensor can be found underneath the arrow key.
>>
>
>> Cc: Matthew Thode <mthode@...ode.org>
>
> Shouldn't be Suggested-by or even Signed-off-by?

The patch is different (Matthew originally suppressed the ACPI event),
so I did not copy the sign-off. Please add Suggested-by, if that is an
acceptable tag.

>> Signed-off-by: David Herrmann <dh.herrmann@...il.com>
>
>
>> +       case TP_HKEY_EV_PALM_DETECTED:
>> +       case TP_HKEY_EV_PALM_UNDETECTED:
>
>> +               /* palm detected hovering the keyboard, forward to user-space
>> +                * via netlink for consumption */
>
> Comment style is
> /*
>  * Multi line comment.
>  * This is an example.
>  */

All other 6 comments in this function follow the style I used here, so
I tried to be consistent. But feel free to amend this change.

Thanks a lot!
David