linux-kernel - Re: [PATCH] target: don't call an unmap callback if a range length is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1515796702.21541.7.camel@haakon3.daterainc.com>
Date:   Fri, 12 Jan 2018 14:38:22 -0800
From:   "Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:     Andrei Vagin <avagin@...nvz.org>
Cc:     target-devel@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] target: don't call an unmap callback if a range length
 is zero

Hi Andrei,

Apologies for the delayed follow up.

On Wed, 2017-12-13 at 13:55 -0800, Andrei Vagin wrote:
> If a length of a range is zero, it means there is nothing to unmap
> and we can skip this range.
> 
> Here is one more reason, why we have to skip such ranges.  An unmap
> callback calls file_operations->fallocate(), but the man page for the
> fallocate syscall says that fallocate(fd, mode, offset, let) returns
> EINVAL, if len is zero. It means that file_operations->fallocate() isn't
> obligated to handle zero ranges too.
> 
> Signed-off-by: Andrei Vagin <avagin@...nvz.org>
> ---
>  drivers/target/target_core_sbc.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

Applied.

Thank you.