linux-kernel - Re: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1801131727520.3470@hadrien>
Date:   Sat, 13 Jan 2018 17:28:07 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Himanshu Jha <himanshujha199640@...il.com>
cc:     yamada.masahiro@...ionext.com, Julia.Lawall@...6.fr,
        Gilles Muller <Gilles.Muller@...6.fr>, nicolas.palix@...g.fr,
        michal.lkml@...kovi.net, cocci@...teme.lip6.fr,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in
 report mode



On Sat, 13 Jan 2018, Himanshu Jha wrote:

> Remove the unncessary part of the warning reported, in the report
> mode, so that a single warning produced does not exceed more than line
> and hence improve readability of the warnings produced in the subsequent
> reports to a file.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

> ---
>  scripts/coccinelle/free/ifnullfree.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/free/ifnullfree.cocci b/scripts/coccinelle/free/ifnullfree.cocci
> index 14a4cd9..a70e123 100644
> --- a/scripts/coccinelle/free/ifnullfree.cocci
> +++ b/scripts/coccinelle/free/ifnullfree.cocci
> @@ -55,5 +55,5 @@ cocci.print_main("NULL check before that freeing function is not needed", p)
>  p << r.p;
>  @@
>
> -msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values."
> +msg = "WARNING: NULL check before some freeing functions is not needed."
>  coccilib.report.print_report(p[0], msg)
> --
> 2.7.4
>
>