linux-kernel - Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180113195205.GB6389@himanshu-Vostro-3559>
Date:   Sun, 14 Jan 2018 01:22:05 +0530
From:   Himanshu Jha <himanshujha199640@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        michal.lkml@...kovi.net, nicolas.palix@...g.fr,
        linux-kernel <linux-kernel@...r.kernel.org>,
        cocci@...teme.lip6.fr
Subject: Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename
 kzalloc-simple to zalloc-simple

On Sat, Jan 13, 2018 at 05:13:36PM -0200, Fabio Estevam wrote:
> On Sat, Jan 13, 2018 at 3:53 PM, Himanshu Jha
> <himanshujha199640@...il.com> wrote:
> 
> > Yes, I used 'git mv'.
> >
> > It doesn't matter when applying through 'git am', both will result the
> > same AFAIK and only difference is that the patch files generated by 'git
> > format-patch' are different. But that is not important I think.
> 
> You missed the -M option when running 'git format'.
> 
> For reviewers it is not that easy to realize that the 448 lines of the
> original file are the same as the ones in the new file.
> 
> The -M option generates a much cleaner patch.

I guess you're right because patch has many lines.
No problem, I will send again with a much cleaner patch. :-)

-- 
Thanks
Himanshu Jha