linux-kernel - Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180113201709.GF205469@bhelgaas-glaptop.roam.corp.google.com>
Date:   Sat, 13 Jan 2018 14:17:09 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: pci/setup-bus: Delete an error message for a failed memory
 allocation in add_to_list()

On Sat, Jan 13, 2018 at 07:15:04AM +0100, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in this function.
> > 
> > If this is an "extra" message, I assume there's some other message?
> > Can you mention where that is in the changelog?
> 
> * Would you like to get a more detailed commit description?

Your commit message says "omit an extra message", which suggests that
there are currently two messages about the memory allocation failure,
and that your patch removes one of them.

If that's the case, it would be nice to know where the other message
is.

If your patch removes the *only* message about the memory allocation
failure, that might be worth doing, but the changelog should be clear
about that and say "I don't think the error message is worthwhile
because the function already returns failure" or something similar.

> * Are you looking for a reminder on the Linux allocation failure report?

I don't know what the "Linux allocation failure report" is.

> > Also, please squash all the drivers/pci patches into one.
> 
> To which other change possibilities do you refer here?

You posted two patches that remove error messages about memory
allocation failures:

  http://lkml.kernel.org/r/dc3922b4-50f6-e7fa-482f-18e6ff5d905f@users.sourceforge.net
  http://lkml.kernel.org/r/fd9d212e-e8da-1aa7-be7f-7bf6d8f1e15f@users.sourceforge.net

These are doing the same thing and could be combined into one patch.

Bjorn